Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor search UX improvements + Critical connector fixes #2259

Merged
merged 11 commits into from
Aug 30, 2024

Conversation

pablodanswer
Copy link
Contributor

@pablodanswer pablodanswer commented Aug 28, 2024

Description

  • Proper fadeout aligned with chat banner
Screenshot 2024-08-28 at 8 54 51 AM
  • Tags now appear earlier in selection and are scrollable (to avoid odd long tag selection pages)
Screenshot 2024-08-28 at 8 55 13 AM
  • Standardized search input

  • Don't show user group selection if no user groups exist

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 4:34pm

@pablodanswer pablodanswer changed the title Ux improvements Minor UX improvements Aug 28, 2024
@pablodanswer pablodanswer changed the title Minor UX improvements Minor search UX improvements Aug 28, 2024
@pablodanswer pablodanswer changed the title Minor search UX improvements Minor search UX improvements + Critical connector fixes Aug 29, 2024
@yuhongsun96 yuhongsun96 merged commit 1835690 into main Aug 30, 2024
6 checks passed
@yuhongsun96 yuhongsun96 deleted the ux_search_selection branch August 30, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants